Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: fix PreDestroy callback support for decorators #36556

Merged
merged 1 commit into from
Oct 19, 2023
Merged

ArC: fix PreDestroy callback support for decorators #36556

merged 1 commit into from
Oct 19, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 18, 2023

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Oct 18, 2023
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2023

Failing Jobs - Building a607a67

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: integration-tests/virtual-threads/amqp-virtual-threads integration-tests/virtual-threads/grpc-virtual-threads integration-tests/virtual-threads/jms-virtual-threads and 9 more

📦 integration-tests/virtual-threads/amqp-virtual-threads

✖ io.quarkus.it.vthreads.amqp.VirtualThreadTest.testAlert line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.amqp.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert",

✖ io.quarkus.it.vthreads.amqp.VirtualThreadTest.testAlertMessage line 36 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.amqp.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert-message",

📦 integration-tests/virtual-threads/grpc-virtual-threads

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testEmpty - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#130,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testGrpcClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#130,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:666)

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testUnary - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#143,executor-thread-4,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testEmpty - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#79,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testGrpcClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testStreamingOutputCall - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#94,executor-thread-2,5,main] is not a virtual thread
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:666)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testUnary - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#94,executor-thread-2,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

📦 integration-tests/virtual-threads/jms-virtual-threads

✖ io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.jms.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert",

✖ io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlertMessage line 36 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.jms.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert-message",

📦 integration-tests/virtual-threads/kafka-virtual-threads

✖ io.quarkus.it.vthreads.kafka.VirtualThreadTest.testAlert line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.kafka.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert",

✖ io.quarkus.it.vthreads.kafka.VirtualThreadTest.testAlertMessage line 36 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.kafka.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert-message",

📦 integration-tests/virtual-threads/mailer-virtual-threads

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.test line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.testWithTemplate line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/quartz-virtual-threads

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.testScheduledMethods line 25 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.virtual.mail.RunOnVirtualThreadTest expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.testScheduledMethodsUsingApi line 38 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.virtual.mail.RunOnVirtualThreadTest expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/virtual-threads/reactive-routes-virtual-threads

✖ io.quarkus.virtual.vertx.web.RunOnVirtualThreadTest.testRouteOnVirtualThread line 20 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:278)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:304)

📦 integration-tests/virtual-threads/redis-virtual-threads

✖ io.quarkus.virtual.redis.RunOnVirtualThreadTest.test line 21 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/rest-client-reactive-virtual-threads

✖ io.quarkus.virtual.rest.RunOnVirtualThreadTest.test line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/resteasy-reactive-virtual-threads

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testFilters line 91 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testGet line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testPost line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testRunOnVirtualThreadOnClass line 73 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/scheduler-virtual-threads

✖ io.quarkus.virtual.scheduler.RunOnVirtualThreadTest.testScheduledMethods line 25 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.virtual.scheduler.RunOnVirtualThreadTest expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

✖ io.quarkus.virtual.scheduler.RunOnVirtualThreadTest.testScheduledMethodsUsingApi line 38 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.virtual.scheduler.RunOnVirtualThreadTest expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/virtual-threads/vertx-event-bus-virtual-threads

✖ io.quarkus.virtual.vertx.RunOnVirtualThreadTest.testOneWay line 23 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.virtual.vertx.RunOnVirtualThreadTest 1 expectation failed.
JSON path size() doesn't match.

✖ io.quarkus.virtual.vertx.RunOnVirtualThreadTest.testRequestReply line 33 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@mkouba mkouba mentioned this pull request Oct 19, 2023
Merged
@mkouba mkouba merged commit cba9cd3 into quarkusio:main Oct 19, 2023
49 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 19, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 19, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
@aloubyansky aloubyansky modified the milestones: 3.5.1, 3.2.8.Final Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Milestone
3.2.8.Final
Development

Successfully merging this pull request may close these issues.

@PostConstruct and @PreDestroy support on @Decorator classes
5 participants
@mkouba @Ladicek @manovotn @aloubyansky @gsmet